-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Malicious site protection navigation detection integration #3730
Open
alessandroboron
wants to merge
12
commits into
alessandro/malicious-site-protection-feature-flags
Choose a base branch
from
alessandro/malicious-site-protection-navigation-detection-integration
base: alessandro/malicious-site-protection-feature-flags
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-navigation-detection-integration
branch
4 times, most recently
from
December 16, 2024 16:07
2096a74
to
0838920
Compare
alessandroboron
commented
Dec 16, 2024
import Foundation | ||
import MaliciousSiteProtection | ||
import Networking | ||
import PixelKit | ||
|
||
final class MaliciousSiteProtectionManager: MaliciousSiteDetecting { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alessandroboron
changed the title
Alessandro/malicious site protection navigation detection integration
Malicious site protection navigation detection integration
Dec 16, 2024
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-feature-flags
branch
from
December 19, 2024 12:48
a41d843
to
99e6543
Compare
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-navigation-detection-integration
branch
from
December 19, 2024 12:49
ed4e32b
to
b5fe830
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208758247571054/f
CC: @not-a-rootkit
Description:
Integrate BSK library for malicious threat detection.
Steps to test this PR:
Prerequisites: Return
true
inMaliciousSiteProtectionFeatureFlags.swift
->isMaliciousSiteProtectionEnabled
andshouldDetectMaliciousThreat(forDomain domain: String?) -> Bool
Scenario 1 - Phishing
Scenario 2 - Malware
Scenario 3 - Leave Site Creates an Empty Tab at same index of the tab closed
Definition of Done (Internal Only):
Copy Testing:
’
rather than'
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template